tree 0240c73e50574ede196b04dc6995503f6b609e4f
parent c9a70fc28ce398a63d7835370de575fec20f826e
author Rebecca Stambler <rstambler@golang.org> 1599971181 -0400
committer Rebecca Stambler <rstambler@golang.org> 1600296803 +0000

internal/lsp: pass options by reference instead of by value

We were previously behaving as though the slice/map values in the
options struct could be modified directly. The options should be cloned
before modification. Also, convert any usage of source.Options to
*source.Options.

Fixes golang/go#39592

Change-Id: Ib39f668bca0fa1038162206bd7793fd2049af576
Reviewed-on: https://go-review.googlesource.com/c/tools/+/254558
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>