| commit | c5032d394f0028702e058dbbabd93c08ddcaea5b | [log] [tgz] |
|---|---|---|
| author | Ian Cottrell <iancottrell@google.com> | Fri Oct 19 16:48:31 2018 -0400 |
| committer | Ian Cottrell <iancottrell@google.com> | Mon Oct 22 15:13:45 2018 +0000 |
| tree | 8e4a4000a882a714ce799486efad432eb55d8f5b | |
| parent | 3e7aa9e59977626dc60433e9aeadf1bb63d28295 [diff] |
go/packages: Fixes for bad wd handling Darwin convertes the working directory to a real path which affects the path a command is started with when you exec. This causes a problem where the path the go list command is run with does not match the path the outside program is trying to use, which causes both undesirably changed paths in it's outputs, and sometimes failures to cope with modules when source files are "outside" the module root. The go standard library has a special feature in os.Getwd where it checks if the PWD environment variable is the same inode as the system cwd, and if it is it returns the PWD instead. This change deliberately sets the PWD before running go list so that behaviour is triggered, which fixes all the paths. This was breaking the mac build bots in a goimports test, it should be fixed now. Change-Id: I0f5d3c7d020b55749738036ba51c19884bb26598 Reviewed-on: https://go-review.googlesource.com/c/143517 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.