commit | c3a8a1d82834956d976acb2cecce7e10d68f8b9c | [log] [tgz] |
---|---|---|
author | Muir Manders <muir@mnd.rs> | Tue Feb 02 21:50:07 2021 -0800 |
committer | Rebecca Stambler <rstambler@golang.org> | Fri Feb 05 19:39:34 2021 +0000 |
tree | d95583c502d76db8abca2f74479791dcad11f75d | |
parent | 842a9283d6c649d9e507c58328438e6f52540eb0 [diff] |
internal/lsp/completion: fix untyped ints to match floats In cases like: foo<> == 100 We weren't preferring floats at <>. Fix the basic type comparison logic to know that an untyped int is always compatible with a float. Fixes golang/go#44066. Change-Id: I9cf9bac1632178db100c0a5447351be208b4a2af Reviewed-on: https://go-review.googlesource.com/c/tools/+/289129 Run-TryBot: Muir Manders <muir@mnd.rs> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Rebecca Stambler <rstambler@golang.org> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.