| commit | c35476fcce7a5770bccd3bfba506393dbcfe679f | [log] [tgz] |
|---|---|---|
| author | Robert Findley <rfindley@google.com> | Fri Jul 07 13:49:23 2023 -0400 |
| committer | Robert Findley <rfindley@google.com> | Tue Jul 11 13:57:10 2023 +0000 |
| tree | 34b167496f053e80bdf453a3e8aefc97b5846d1b | |
| parent | ec9bc534250242bd1c9995a21bfe037ef0d35c9d [diff] |
gopls: commands to start/stop profiling, and a new benchmark metric Total CPU used by gopls is a critical metric for our users, yet was not previously captured in any benchmark. This change uses the new pprof parsing utilities added in CL 507885 to instrument a cpu_seconds benchmark metric, for now just associated with the DidChange benchmark. This is achieved via new LSP commands that start and stop a profile. The benchmark runner uses these commands to bracket the critical section of the benchmark, then parses the resulting profile for its total sampled CPU. Additionally, the benchmark runner is updated to actually check for the existence of the custom command before instrumenting the new metric. This allows it to be compatible with testing older versions of gopls. The same technique is adopted for memstats metrics. I only instrumented BenchmarkDidChange, because the profile file schema is getting truly out of hand. I'll try to simplify it before instrumenting all the other benchmarks, but want to do that in a separate CL. For golang/go#60926 Change-Id: Ia082bad49e8d30c567a7c07e050511d49b93738b Reviewed-on: https://go-review.googlesource.com/c/tools/+/508449 gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph prints the call graph of a Go program.cmd/digraph is a utility for manipulating directed graphs in textual notation.cmd/stringer generates declarations (including a String method) for “enum” types.cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis provides a framework for modular static analysis of Go programs.
go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg provides a simple control-flow graph (CFG) for a Go function.
go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.
go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.