)]}'
{
  "commit": "c24ae10e7b5734decca2d647ddcf4e3f929f007d",
  "tree": "5ccd3b21925678547eb6017c6ff976634136ae35",
  "parents": [
    "6e3b208b986ce9d4f5368198b9efb406799f3695"
  ],
  "author": {
    "name": "Alan Donovan",
    "email": "adonovan@google.com",
    "time": "Wed Jun 05 23:33:57 2024 -0400"
  },
  "committer": {
    "name": "Alan Donovan",
    "email": "adonovan@google.com",
    "time": "Fri Jun 07 14:36:04 2024 +0000"
  },
  "message": "gopls/internal/cmd: cleanup progress handling\n\nThis CL adds connection.registerProgressHandler so that\neach call to, say, executeCommand can temporarily install\na handler for progress notifications bearing the token\npassed to executeCommand.\n\nHowever, the initial workspace load must be treated a little\nspecially since it occurs during the initialize RPC, which\nhappens before the newConnection constructor has returned.\nSo, tracking the IWL is now a core feature of connection\ninstead of something local to the \u0027stats\u0027 subcommand.\n\nAlso, make the \"asynchronous\" property a declarative\nattribute of each command.Command so that both the server\nand the client can do the right thing--start a thread,\nwait for the \u0027end\u0027 notification--based on the metadata.\n\nAlso:\n- use connection.executeCommand in all cases instead of\n  direct call to ExecuteCommand.\n- merge Application.connect{,remote} and factor common logic.\n\nChange-Id: If7a000593ef4d4dc5658423a03c56b2f4f3a06ca\nReviewed-on: https://go-review.googlesource.com/c/tools/+/591095\nReviewed-by: Robert Findley \u003crfindley@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c1c5bead12154383ee9928a9818c26529640485a",
      "old_mode": 33188,
      "old_path": "gopls/doc/commands.md",
      "new_id": "1e153100c915be18fd11ae09f614912921f7addb",
      "new_mode": 33188,
      "new_path": "gopls/doc/commands.md"
    },
    {
      "type": "modify",
      "old_id": "82c18d0d28fbbaf9853ca2aee3ab6f5f9f49f0d9",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/call_hierarchy.go",
      "new_id": "0ac6956144e9fea6a27e6bef41ab61f6be19ab03",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/call_hierarchy.go"
    },
    {
      "type": "modify",
      "old_id": "e043f68eb2995832c527267b4b6da3ab6caf2121",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/capabilities_test.go",
      "new_id": "97eb49652d081348ab65bdddcd1e533e53988e49",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/capabilities_test.go"
    },
    {
      "type": "modify",
      "old_id": "7a0d19f85d881a01b902133ee91b98ed972d92b3",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/check.go",
      "new_id": "a859ed2c7088f32e2c02e9050b3fdd77141bb225",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/check.go"
    },
    {
      "type": "modify",
      "old_id": "ba3a0b1a74c456bdb295c541f08de3967221c249",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/cmd.go",
      "new_id": "b3e5dbe0cb800d24d04bdc89ce0714a9dedbbf9c",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/cmd.go"
    },
    {
      "type": "modify",
      "old_id": "a7017d8e3f10d4713b39f65694b0486d5ef02175",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/codelens.go",
      "new_id": "b07f15429ceab60e82dec9182f456f21e37c1c95",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/codelens.go"
    },
    {
      "type": "modify",
      "old_id": "e5e119b8da84250e8399b75bcb60d4dd155469f4",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/definition.go",
      "new_id": "d9cd98554e3e84c6d6ba67f7ae0b94994a53f624",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/definition.go"
    },
    {
      "type": "modify",
      "old_id": "381c2a7aa958dd5178cad6e88bffdd1adc347b93",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/execute.go",
      "new_id": "485e6d03ca9334398d4cdd2a5e45c7eaf33d9fb2",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/execute.go"
    },
    {
      "type": "modify",
      "old_id": "13f78c197a548dfd6151194747ff6115070dd44a",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/folding_range.go",
      "new_id": "f48feee5b2ce904b07ca407d57115af502ba339a",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/folding_range.go"
    },
    {
      "type": "modify",
      "old_id": "75982c9efba2cc2530c712d5b1a01cbfca2742ba",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/format.go",
      "new_id": "eb68d73d527f61b9b808d656fec1724c526f9d3c",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/format.go"
    },
    {
      "type": "modify",
      "old_id": "9c1488b30be93bc77f61dfda951de171783b352f",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/highlight.go",
      "new_id": "43af063f53feceb7251951ab34838e0703641800",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/highlight.go"
    },
    {
      "type": "modify",
      "old_id": "fcfb63185b4f1b52271dd1e8bd3cd5b41f8bc8fe",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/implementation.go",
      "new_id": "858026540adc9ccae76541f2c437aaf24ab509e9",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/implementation.go"
    },
    {
      "type": "modify",
      "old_id": "12b49ef254de21ef91dbf8108f8d85d3c49bf05a",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/imports.go",
      "new_id": "c64c871e390cbb49ebac91fc142ee700e58e3af4",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/imports.go"
    },
    {
      "type": "modify",
      "old_id": "0f1d671a5036e72147cb9e8a10382447e5491702",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/links.go",
      "new_id": "3c14f4e66081aede0bb76f5a2563f53e6c7d5f09",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/links.go"
    },
    {
      "type": "modify",
      "old_id": "c7901e6484dbc624dfa1870027b6ae20e95a9aa9",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/prepare_rename.go",
      "new_id": "3ff38356d5573246ef80bc27da83efa5e46eee47",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/prepare_rename.go"
    },
    {
      "type": "modify",
      "old_id": "3c294c71b14deb8b354c41fdd65e4dec30b409e8",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/references.go",
      "new_id": "1483bf12db0d15eac412bd663a7e8ee76f9ba014",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/references.go"
    },
    {
      "type": "modify",
      "old_id": "6d831681c192f686142b4b61ee9e4f0304c958be",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/rename.go",
      "new_id": "e96850cd1c87368b272870243c28a26899482bd3",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/rename.go"
    },
    {
      "type": "modify",
      "old_id": "572962116e8ab8e7620f4e459ee760933f280e0d",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/semantictokens.go",
      "new_id": "77e8a03939cff805729be4cdbde961e2e13178c1",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/semantictokens.go"
    },
    {
      "type": "modify",
      "old_id": "cf976a64859fc2455c4551923f11c8b1056307e3",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/signature.go",
      "new_id": "601cfaa13fa6cc6dcb612ba025b70724c083e9a2",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/signature.go"
    },
    {
      "type": "modify",
      "old_id": "8da1a1a6ae8e797e1857bd92ccba2f618ca167c1",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/stats.go",
      "new_id": "a78880107e7ac03cf6cab7b3b729b64eae8e6628",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/stats.go"
    },
    {
      "type": "modify",
      "old_id": "e066460526d8506fbb280acc729ac40bf8c2821d",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/suggested_fix.go",
      "new_id": "a326c9225f0ec6bb55a9990825119e9d0776981d",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/suggested_fix.go"
    },
    {
      "type": "modify",
      "old_id": "249397d320fc329a59890ef85b1e4c94d12ef6e3",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/symbols.go",
      "new_id": "663a08f4be1afdf94731d450f9bf13821eaec191",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/symbols.go"
    },
    {
      "type": "modify",
      "old_id": "9fa7526a24d26df3bddf3f2c230f4ce4ee115b82",
      "old_mode": 33188,
      "old_path": "gopls/internal/cmd/workspace_symbol.go",
      "new_id": "aba33fa9d2a6fbecd85f07ac05ba902fb6f79502",
      "new_mode": 33188,
      "new_path": "gopls/internal/cmd/workspace_symbol.go"
    },
    {
      "type": "modify",
      "old_id": "bcb2610a897a911389c11237f257c8250f9b2caa",
      "old_mode": 33188,
      "old_path": "gopls/internal/doc/api.json",
      "new_id": "e17038511a9fb96cdc7e133a09cafd68307057b9",
      "new_mode": 33188,
      "new_path": "gopls/internal/doc/api.json"
    },
    {
      "type": "modify",
      "old_id": "0f4402641c96f1699de94c7ecb160e21371f105d",
      "old_mode": 33188,
      "old_path": "gopls/internal/protocol/command/interface.go",
      "new_id": "0934cf22dc4b6d5ea72622f92d051dc1dbadabb3",
      "new_mode": 33188,
      "new_path": "gopls/internal/protocol/command/interface.go"
    },
    {
      "type": "modify",
      "old_id": "f49e0404ea0d593b3ef90eb983100023f569a9a5",
      "old_mode": 33188,
      "old_path": "gopls/internal/protocol/command/util.go",
      "new_id": "0d9799f5dc01b823ad2072ab76929f582951e323",
      "new_mode": 33188,
      "new_path": "gopls/internal/protocol/command/util.go"
    },
    {
      "type": "modify",
      "old_id": "f7bf1aadd6f5b5d5c4c195b39293a58161d68c58",
      "old_mode": 33188,
      "old_path": "gopls/internal/server/command.go",
      "new_id": "ad2eb9501d58568f54af38b16e544ca48294f778",
      "new_mode": 33188,
      "new_path": "gopls/internal/server/command.go"
    }
  ]
}