Google Git
Sign in
go / tools / c1a7fcfc101d2fdf16ba2d1175509e2671cb2bcc
commitc1a7fcfc101d2fdf16ba2d1175509e2671cb2bcc[log] [tgz]
authorxzb <2598514867@qq.com>Tue Jan 07 20:30:46 2025 +0000
committerGopher Robot <gobot@golang.org>Fri Jan 10 08:09:31 2025 -0800
tree1068dc06402aa3851c3c4f6362438ef070200238
parent1b796a93b9c5e1f507618de1d18d5908df5e3702 [diff]
go/analysis/passes/printf: extract operation parsing logic into tools/internal/fmtstr

This CL made a refactor that extract operation parsing logic into
tools/internal/fmtstr package, so they can be used uniformly by
printf-analyzer for type checking, DocumentHighlight, and future
possibility for SemanticHighlight and rich Hover information with little effort.

Previously, the code responsible for parsing and validating printf-style
format strings was spread inline and blend together in printf.go,
in order to use it for documenthighligt/hover, this CL extends formatState
by encoding posRange and metainfo for every sub-item of a operation
(flag, width, precision, verb), and only expose those field, by that way
callers can compute necessary information from them for various usages.

Updates golang/go#70050

Change-Id: I8337ad0bdf9f5c1aa301d2e9155b2d4938cf4a7c
GitHub-Last-Rev: 8e576345020d79d5c5534f8e66c3eee5f7bb2edd
GitHub-Pull-Request: golang/tools#547
Reviewed-on: https://go-review.googlesource.com/c/tools/+/632598
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
4 files changed
tree: 1068dc06402aa3851c3c4f6362438ef070200238
  1. benchmark/
  2. blog/
  3. cmd/
  4. container/
  5. copyright/
  6. cover/
  7. go/
  8. godoc/
  9. gopls/
  10. imports/
  11. internal/
  12. playground/
  13. present/
  14. refactor/
  15. txtar/
  16. .gitattributes
  17. .gitignore
  18. .prettierrc
  19. codereview.cfg
  20. CONTRIBUTING.md
  21. go.mod
  22. go.sum
  23. LICENSE
  24. PATENTS
  25. README.md
README.md

Go Tools

PkgGoDev

This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.

It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.

Selected commands:

  • cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.
  • cmd/callgraph prints the call graph of a Go program.
  • cmd/digraph is a utility for manipulating directed graphs in textual notation.
  • cmd/stringer generates declarations (including a String method) for “enum” types.
  • cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.

These commands may be fetched with a command such as

go install golang.org/x/tools/cmd/goimports@latest

Selected packages:

  • go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.

  • go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.

  • go/analysis provides a framework for modular static analysis of Go programs.

  • go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.

  • go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.

  • go/cfg provides a simple control-flow graph (CFG) for a Go function.

  • go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.

  • go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.

Numerous other packages provide more esoteric functionality.

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes, see https://go.dev/doc/contribute.

The git repository is https://go.googlesource.com/tools.

The main issue tracker for the tools repository is located at https://go.dev/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.

JavaScript and CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.