tree 547dc21b8929c873ebd2ad47ad20b7790e8e4129
parent be796f87a6632647db1d99d3e0ca7801ecdb5a46
author Rebecca Stambler <rstambler@golang.org> 1605805821 -0500
committer Rebecca Stambler <rstambler@golang.org> 1605813166 +0000

internal/lsp/fake: hold the mutex for all of SaveBufferWithoutActions

This addresses the race seen in
https://storage.googleapis.com/go-build-log/5ba1c3f2/windows-386-2008_2bf3acc7.log.

Paraphrased from Rob in chat:

The race is triggered because of the additional asynchronous handling of
file changes added to sync non-dirty files on disk changes. The buffer
is marked as non-dirty, THEN the on-disk change is processed, sending a
didChange, THEN the didSave is sent (https://golang.org/cl/267577).

Also, don't send didChange for formatting if nothing has changed.

Change-Id: Ibc6a55d35dee99c04dadf5470c2d68ca937f849b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/271578
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>