commit | c03e5c28b0de2baba6bca5e509da618d0c3a4692 | [log] [tgz] |
---|---|---|
author | Nikolay Edigaryev <edigaryev@gmail.com> | Wed Jul 31 17:35:01 2024 +0000 |
committer | Alan Donovan <adonovan@google.com> | Mon Aug 05 15:06:34 2024 +0000 |
tree | 410b8e72400d1d8617bfb29bb949a8b70045a901 | |
parent | 6a6fd991e914cbc2859fd968949132085277a6d0 [diff] |
go/packages: do not nullify Fset when NeedSyntax is set Currently, Fset is initialized when either NeedTypes or NeedSyntax are set in newLoader(). However, later in refine() it is nullified using a different condition that doesn't take NeedSyntax into account. Use the inverse condition to that of in newLoader() when deciding on whether to nullify Fset or not. Resolves https://github.com/golang/go/issues/48226. Change-Id: Ic7c05dfe3337d5cf14aa185350a8e766e224c898 GitHub-Last-Rev: a9068719f659ac11a5846d9b8c46850b2103aa77 GitHub-Pull-Request: golang/tools#506 Reviewed-on: https://go-review.googlesource.com/c/tools/+/601239 Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@golang.org>
This repository provides the golang.org/x/tools
module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls
module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports
formats a Go program like go fmt
and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph
prints the call graph of a Go program.cmd/digraph
is a utility for manipulating directed graphs in textual notation.cmd/stringer
generates declarations (including a String
method) for “enum” types.cmd/toolstash
is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa
provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages
provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis
provides a framework for modular static analysis of Go programs.
go/callgraph
provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector
provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg
provides a simple control-flow graph (CFG) for a Go function.
go/expect
reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata
and go/gccgoexportdata
read and write the binary files containing type information used by the standard and gccgo
compilers.
go/types/objectpath
provides a stable naming scheme for named entities (“objects”) in the go/types
API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.