tree 7f1b1eedfe0fa2dabdc4aaab3c6ef0b9f38e50d4
parent 0d28b7d7c5d3e92e5d8a41c9b40ececd7e81ab9f
author Rob Findley <rfindley@google.com> 1627672313 -0400
committer Robert Findley <rfindley@google.com> 1628540460 +0000

internal/lsp: update the fuzzy matcher to operate on chunks

We can avoid allocating strings when performing workspace symbol search
by having the fuzzy match operate directly on chunks.

When operating on a single string, this slows down the matcher slightly
(perhaps 10%) due to copying bytes rather than accessing the string
directly. We could work around this using unsafe, but this could also be
mitigated by generics.

Benchmark ("test" in x/tools): 48ms->46ms
Benchmark ("test" in kubernetes): 868ms->857ms

Change-Id: Icf0f15aaa5cc3c875cf157a7b90db801045d9ed4
Reviewed-on: https://go-review.googlesource.com/c/tools/+/338694
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>