commit | bcec0994e0bf81991b2e35f788768c9074a20152 | [log] [tgz] |
---|---|---|
author | Rob Findley <rfindley@google.com> | Fri Apr 12 18:37:50 2024 +0000 |
committer | Gopher Robot <gobot@golang.org> | Fri Apr 26 17:54:19 2024 +0000 |
tree | 69509fbb2fedb2f46561cda405d0ed4e24876165 | |
parent | fcea13b66c45c5ca16dfb1d36479ec79d3d68c15 [diff] |
internal/refactor/inline: remove eta abstraction inlining assignments Remove the unnecessary eta abstraction reported in golang/go#65217, by introducing a new strategy for rewriting assignments. This strategy involves analyzing both LHS and RHS of an assignment, and choosing between three substrategies: - spread the result expressions in cases where types are unambiguous - predeclare LHS variables in cases where the return is itself a spread call - convert RHS expressions if types involve implicit conversions Doing this involved some fixes to the logic for detecting trivial conversions, and tracking some additional information about untyped nils in return expressions. Since this strategy avoids literalization by modifying assignments in place, it must be able to avoid nested blocks, and so it explicitly records that braces may be elided. There is more work to be done here, both improving the writeType helper, and by variable declarations, but this CL lays a foundation for later expansion. For golang/go#65217 Change-Id: I9b3b595f7f678ab9b86ef7cf19936fd818b45426 Reviewed-on: https://go-review.googlesource.com/c/tools/+/580835 Reviewed-by: Alan Donovan <adonovan@google.com> Auto-Submit: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This repository provides the golang.org/x/tools
module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls
module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports
formats a Go program like go fmt
and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph
prints the call graph of a Go program.cmd/digraph
is a utility for manipulating directed graphs in textual notation.cmd/stringer
generates declarations (including a String
method) for “enum” types.cmd/toolstash
is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa
provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages
provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis
provides a framework for modular static analysis of Go programs.
go/callgraph
provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector
provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg
provides a simple control-flow graph (CFG) for a Go function.
go/expect
reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata
and go/gccgoexportdata
read and write the binary files containing type information used by the standard and gccgo
compilers.
go/types/objectpath
provides a stable naming scheme for named entities (“objects”) in the go/types
API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.