| commit | a6aac22fcd4101d97735d0368fb5d703ba45db24 | [log] [tgz] |
|---|---|---|
| author | Muir Manders <muir@mnd.rs> | Thu Dec 05 21:34:17 2019 -0800 |
| committer | Rebecca Stambler <rstambler@golang.org> | Mon Dec 16 21:36:29 2019 +0000 |
| tree | ee4a3ac82820d1e5c5122ecd7da66f7151ae1178 | |
| parent | 53d48bfcf544a006a229aeb4d4ffdb6c4c9fa855 [diff] |
internal/lsp: fix find-implementation for promoted methods We weren't returning promoted methods as implementations when the promoted method was defined in a different package than the type implementing the interface. Fix by properly mapping the implementer types.Object to its containing source.Package. I generalized the implementations() result to just contain the implementer objects and their containing package. This allowed me to get rid of some result prep code in Implementation(). Fixes golang/go#35972. Change-Id: I867f2114c34e2ad39515ee3c8b6354c1cd35f7af Reviewed-on: https://go-review.googlesource.com/c/tools/+/210280 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.