)]}' { "commit": "bc8aaaa29e0665201b38fa5cb5d47826788fa249", "tree": "8f224fe8baf9844ce6b9e11a9ce91841235e9ab0", "parents": [ "f57a28cb8c0ec56659c07473c7dde628a4f4ec67" ], "author": { "name": "Danish Dua", "email": "danishdua@google.com", "time": "Mon Aug 24 19:49:55 2020 -0400" }, "committer": { "name": "Danish Dua", "email": "danishdua@google.com", "time": "Wed Aug 26 04:07:57 2020 +0000" }, "message": "internal/lsp: ignore period (\u0027.\u0027) triggered completions in comments\n\nPeriod triggered completions don\u0027t provide any use in comments and in\nworst case can be nuisance. LSP provides a completion context which\nprovides more info about what triggered a completion and hence we can\nuse this to ignore period triggererd completions. This will also provide\nus options to deal with retriggered completions etc. better in the\nfuture.\n\nChange-Id: I8449aee0fe3cf5f9acf315865ac854d5c894d044\nReviewed-on: https://go-review.googlesource.com/c/tools/+/250337\nRun-TryBot: Danish Dua \u003cdanishdua@google.com\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Rebecca Stambler \u003crstambler@golang.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "aa285251b1f2caedada99517238121c2c147de30", "old_mode": 33188, "old_path": "internal/lsp/completion.go", "new_id": "221ca9e2b6886191dde60689400414d75a46bdcf", "new_mode": 33188, "new_path": "internal/lsp/completion.go" }, { "type": "modify", "old_id": "bca2ac2e64abadc67a2e658d329ae4a6e8f182a3", "old_mode": 33188, "old_path": "internal/lsp/source/completion.go", "new_id": "43eb01c0011e4eff2230c4e9786bbfc5b3c63186", "new_mode": 33188, "new_path": "internal/lsp/source/completion.go" }, { "type": "modify", "old_id": "657b98ec1ec1fe60fe996fe36cd5c3ff88bbf02d", "old_mode": 33188, "old_path": "internal/lsp/source/source_test.go", "new_id": "85f55bd1c84ddc0b777727ebdf8617c95e342797", "new_mode": 33188, "new_path": "internal/lsp/source/source_test.go" } ] }