| commit | b894a3290fff7ed8373c3156460600f8216a6c2d | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Fri Oct 16 13:52:52 2020 -0400 |
| committer | Heschi Kreinick <heschi@google.com> | Mon Oct 19 17:57:15 2020 +0000 |
| tree | f96c9f46b44396ddb0880ab79ac972d85753ee58 | |
| parent | 0a3dcccdcf7ac1c72c5b03aa5c6bf52603cf5e25 [diff] |
all: use explicit -mod, -modfile fields for gocommand.Invocation Build flags, -mod, and -modfile are all accepted by disjoint go command verbs. Mixing them together had the effect of forcing gocommand users to figure out which went where themselves, which was annoying and error-prone. Add ModFlag and ModFile fields to Invocation and update all uses to use them. go/packages has a BuildFlags field that's bad for the same reason. Add private modFlag and modFile fields that forward to the corresponding Invocation fields. imports.ProcessEnv gets the same treatment. Fixes golang/go#41826. Change-Id: If74d19146e9e62930d7c34f40859c27c25566c4e Reviewed-on: https://go-review.googlesource.com/c/tools/+/263213 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.