tree 07b2c6c85e97116cde7f8b45ba6179b429991644
parent 313af968cc61a742de575868075a9a98ca574667
author Zvonimir Pavlinovic <zpavlinovic@google.com> 1651881426 -0700
committer Zvonimir Pavlinovic <zpavlinovic@google.com> 1652122925 +0000

go/analysis/passes/httpresponse: inspect enclosing context of resp, err

The resp, err results of, say, http.Get can immediatelly be passed to a
helper function that checks err and returns resp. In that case, it is ok
for defer to occur immediately after.

The checker currently assumes that a call to, say, http.Get is the only
call made when a resp is returned. The fix is to check if the original
call is made as a part of another (helper) call and, if so, punt.

For golang/go#52661

Change-Id: If9dc4815013476de381fe69548d1fb9c04aa9fd9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/404656
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>