commit | b8469989bc69e50ec6dc4e4513fc3ff9ce48b8af | [log] [tgz] |
---|---|---|
author | Rob Findley <rfindley@google.com> | Thu May 07 12:25:33 2020 -0400 |
committer | Robert Findley <rfindley@google.com> | Fri May 08 18:47:54 2020 +0000 |
tree | 2bb72c8db25c37b1833c8ce4352a243ad2053693 | |
parent | 88bf40a80d8735d138acdac0d2e35636f250e5b9 [diff] |
internal/lsp/fake: fix some messiness around client hooks While writing the fake editor, I added some state tracking without using it (log messages, events etc). We have since duplicated this logic in the regtest package using client hooks. Fix two messy aspects of this: - remove the state tracking in the editor - pass in the client hooks when connecting, so that they may be used without locking, and so that we do not miss any hooks that may fire during session initialization. Change-Id: I24c17a28e9cfa4fca32b7ddd17c7bf01cbb12e0f Reviewed-on: https://go-review.googlesource.com/c/tools/+/232744 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.