commit | b79f76fe3e9733fa292a2a558160b3658f45f187 | [log] [tgz] |
---|---|---|
author | Matthew Dempsky <mdempsky@google.com> | Mon Feb 15 23:42:21 2021 -0800 |
committer | Matthew Dempsky <mdempsky@google.com> | Wed Feb 17 06:45:53 2021 +0000 |
tree | c93118fc823b05446b5d83d146c321ea8006c6b6 | |
parent | 7fde01ffd3cdad86ebc5c73c80edd1aeebb255b9 [diff] |
go/internal/gcimporter: fix reexporting compiler data The current versions of the indexed export format encode constant values based on their type. However, IExportData was encoding constants values based on their own kind instead. While cmd/compile internally keeps these matched, go/types does not guarantee the same (see also golang/go#43891). This CL fixes this issue, and also extends testing to check reading in the compiler's export data and that imported packages can be exported again. Change-Id: I08f1845f371edd87773df0ef85bcd4e28f5db2f5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/292351 gopls-CI: kokoro <noreply+kokoro@google.com> Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.