tree 4cd0ba29376ff9072ac6d6d850fb4d1cdd3d98c3
parent a9763abba00f0731b51ee7bc61656fc4d5ec239c
author Heschi Kreinick <heschi@google.com> 1605845017 -0500
committer Heschi Kreinick <heschi@google.com> 1606158590 +0000

internal/lsp: use pointers to source.Error, and not to ErrorList

We should be consistent about whether we pass around Error or *Error.
*Error was somewhat more common, and its Error method has a pointer
receiver, so I picked *Error.

ErrorList, on the other hand, is usually dereferenced when used, and
slice headers are small enough to pass around casually. So switch that
over to a non-pointer and change its Error method to a value receiver.

Change-Id: I19e70201ed1d6ef36d217db21c9101bb810bcf0c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/272092
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>