commit | 8860a70d10e6875a63af73f22140e675b250a56f | [log] [tgz] |
---|---|---|
author | Rebecca Stambler <rstambler@golang.org> | Fri Oct 30 00:30:19 2020 -0400 |
committer | Rebecca Stambler <rstambler@golang.org> | Mon Nov 02 02:19:07 2020 +0000 |
tree | d5a61a7296b2772085f8bdd82cd7ee35018a50a9 | |
parent | 51cde5226ead67dcfd635a510180cc1417186271 [diff] |
internal/lsp/cache: set a 15 minute deadline on calls to packages.Load We've recently noticed multiple instances of `go list` hanging indefinitely during an initial workspace load. Heschi suggested setting a 5 minute deadline on the IWL, but it seems reasonable to set this deadline on all calls to packages.Load since that calls `go list`. I also started with a 15 minute deadline to be a little more careful. Do you think this is risky enough to merit an experimental setting? Fixes golang/go#42132 Change-Id: I0a38741f3d99b6a38c46c3e663daf61f2cb45581 Reviewed-on: https://go-review.googlesource.com/c/tools/+/266478 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.