commit | b4639ccb830b1c9602f1c96eba624bbbe20650ea | [log] [tgz] |
---|---|---|
author | pjw <pjw@google.com> | Sun Feb 21 15:40:02 2021 -0500 |
committer | Peter Weinberger <pjw@google.com> | Tue Feb 23 19:09:02 2021 +0000 |
tree | 65dae340e0cc6640f02afa1863d14600ccb14708 | |
parent | a43f69b1f5e22e6a9892effdfa50d1f867db4c89 [diff] |
internal/lsp/protocol: fix vet error in tsprotocol.go Vet complained about multiple definitions of the 'workspace' tag. The underlying error was a failure to do type merging in alias types, coupled with relying on luck when generating types and deciding which type definitions to store. (Luck almost worked, but more careful type merging made it too risky.) The only noticeable change (outside tsprotocol.go) is that the generated type names used in general.go now have serial numbers in them. tsserver.go and tsclient.go just have new dates in their headers, but are otherwise unchanged. tsprotocol.go has more generated types (Workspace.*Gn). (There are probably more types than are needed, but fixing that is for the future.) All the tests pass and gopls seems to work ok. The revised code.ts will be submitted in a future CL. Change-Id: I7082755c327e7b6ebec57d4449eec1e0cc50fcd5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/294909 gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Peter Weinberger <pjw@google.com> Run-TryBot: Peter Weinberger <pjw@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.