| commit | b346f7fd45de50e7e5dd5d24a7a009c3c8d8ec61 | [log] [tgz] |
|---|---|---|
| author | Sander van Harmelen <sander@vanharmelen.nl> | Wed Aug 07 23:49:42 2019 +0200 |
| committer | Rebecca Stambler <rstambler@golang.org> | Wed Aug 07 22:35:07 2019 +0000 |
| tree | 8d3a21c5161e23c5b1973308d4ff4c7c538607ea | |
| parent | 8be58fba63529bbb3f25f43fe10179356ca2497e [diff] |
x/tools/cmd/gopls: prevent nil pointer dereferences The `files` slice is used twice. First it's used to get all results from `ph.Parse`, and then it's reused to filter all `nil` values (which may have been returned by the `ph.Parse` method). After the loop to "filter" out all the `nil` values, we also need to strip the remaining values. I also changed the ordering so that we first check the errors and only then perform this loop. That way the code will return earlier when the context was canceled. Partially fixes #33531 by prevention the panic reported in that issue. Change-Id: I09478e765adcd0384ec4745921eb5c5aea405ef2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/189397 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.