tree a58372bf10f27312bdebf7e4afc1011e775f5ba5
parent 3cb82d5f9c98d67e87672ca017a22189388bffa3
author Alan Donovan <adonovan@google.com> 1670862719 -0500
committer Alan Donovan <adonovan@google.com> 1671117111 +0000

gopls/internal/lsp/cache: reduce type-checking in renameImports

Before, package renaming would type-check the entire reverse
transitive closure. This change avoids type checking for indirect
reverse dependencies, or when the package's (leaf) name hasn't
changed.

The references operation also uses the new APIs (to request metadata
separate from type checking), and uses it to avoid type checking
entirely when computing references to a package name,
but doesn't yet economize on the set of packages it type checks
in the general case. That will come in a follow-up; eventually
of course it will be based on a search index, not type checking.

Also:
- fix vendoring issues flagged by TODO.
- Snapshot.ReverseDependencies now returns only metadata, no type checking.
- metadataGraph.reverseTransitiveClosure returns a map.
- added source.RemoveIntermediateTestVariants helper.
- deleted snapshot.checkedPackage, no longer needed.

Change-Id: Ia17c9d9c7922a45cf9b6e1bb86c4919a60da0215
Reviewed-on: https://go-review.googlesource.com/c/tools/+/456759
Run-TryBot: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>