commit | b2a7f28a184a6e7aea33316b2d8a321cc9d7e138 | [log] [tgz] |
---|---|---|
author | Rebecca Stambler <rstambler@golang.org> | Tue Oct 29 12:16:15 2019 -0400 |
committer | Rebecca Stambler <rstambler@golang.org> | Wed Oct 30 00:30:36 2019 +0000 |
tree | 662afc854759dd00b6b992c75d72e8c7c94eaeb9 | |
parent | 521f1f80feee884d38779d967745c52b49ab86b8 [diff] |
internal/lsp: do not close over the handle in the memoize function Closing over the checkPackageHandle creates a cycle that forces the checkPackageHandle not to be garbage collected until the value is created. If a value is never created, the handle will not be collected. Change-Id: I0f94557da917330ebe307a0e843b16ca7382e210 Reviewed-on: https://go-review.googlesource.com/c/tools/+/204079 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.