commit b2746f1d7ac671e79e3fc21906e664f9d2c20496
author Rebecca Stambler <rstambler@golang.org> Sun Oct 18 22:17:23 2020 -0400
committer Rebecca Stambler <rstambler@golang.org> Mon Oct 19 15:59:33 2020 +0000
tree 1d592c73d017b27a7e4681d7072fd79d267dd27d
parent 6003fad69a889b43c22ce72e5796412a20301c5e

internal/lsp: fix nil pointer exception in initialization

Fixes golang/vscode-go#802

Change-Id: Ide3e834d413efcb394370a0c2e5ffa412a45e1a3
Reviewed-on: https://go-review.googlesource.com/c/tools/+/263520
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Peter Weinberger <pjw@google.com>

internal/lsp/cache/view.go

diff --git a/internal/lsp/cache/view.go b/internal/lsp/cache/view.go
index 3bec5ec..8b3d307 100644
--- a/internal/lsp/cache/view.go
+++ b/internal/lsp/cache/view.go
@@ -546,6 +546,10 @@
 					addError(mod.modURI, err)
 					continue
 				}
+				if parsed.File == nil || parsed.File.Module == nil {
+					addError(mod.modURI, fmt.Errorf("no module path for %s", mod.modURI))
+					continue
+				}
 				path := parsed.File.Module.Mod.Path
 				scopes = append(scopes, moduleLoadScope(path))
 			}