tree bca8dc5360ef95f50475bc687473c37f77aa9e6c
parent e78b40c7d0f9973e4a8ae8836f4b2131292d5609
author Keith Randall <khr@golang.org> 1617829899 -0700
committer Keith Randall <khr@golang.org> 1617847725 +0000

go/tools: add vet check for direct comparion of reflect.Values

Comparing reflect.Values directly is almost certainly not what you want.
That compares reflect's internal representation, not the underlying
value it represents. One compares reflect.Values correctly by comparing
the results of .Interface() calls.

Fixes golang/go#43993
Update golang/go#18871

Change-Id: I6f441d920a5089bd346e5431032780403cefca76
Reviewed-on: https://go-review.googlesource.com/c/tools/+/308209
Trust: Keith Randall <khr@golang.org>
Trust: Joe Tsai <thebrokentoaster@gmail.com>
Run-TryBot: Keith Randall <khr@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>