tree 63c04f0dfa8d9fb3e1fc9c107caacd9bddd4e8de
parent 88b5529c9e152818a95a94bba07f34ce60532bb0
author Robert Findley <rfindley@google.com> 1663766891 -0400
committer Robert Findley <rfindley@google.com> 1663941125 +0000

gopls/internal/lsp/tests: simplify collectCompletionItems, remove Data.t

The marker function collectCompletionItems required at least three
arguments. Express this in its signature, leaving a final variadic
argument for documentation. I considered just making this final argument
mandatory, but opted for minimizing the diff given that there are 400+
existing @item annotations.

With this change the only use of tests.Data.t is in mustRange. Since
conversion to range should always succeed, I switched this usage to a
panic and removed the t field.

For golang/go#54845

Change-Id: I407f07cb85fa1356ceb6dba366007f69d1b6a068
Reviewed-on: https://go-review.googlesource.com/c/tools/+/432337
Reviewed-by: Alan Donovan <adonovan@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>