tree 7b3b77c356ba5b75ff31fbc67e68fb7ba81802e2
parent 816ec5aa880a139d9592b0add28e87909580a9ab
author Peter Weinberger <pjw@google.com> 1783713640 -0400
committer Peter Weinberger <pjw@google.com> 1783960917 -0700

gopls/internal/completion: fix issue 80268

When completing the argument to func foo(_ *[10]int), the existing
code can produce syntactically invalid code because it discards
a conversion to slice.

More precisely: in
func foo(p *[10]int) {}
func bar() {
	var array [10]int
	foo(arr<cursor>)
}
the completion at 'arr' was (*[10]int)(array), but the code should
have produced (*[10]int)(array[:]). [Even better would have been
&array, but that's not how the completion logic is organized.]

Fixes: golang/go#80268
Change-Id: Ief2ccc963d30cd275d8383b110fbd3b40661534f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/799560
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Madeline Kalil <mkalil@google.com>