tree 38e34ee53f061cba41ccc98dcdaf0d776fa39329
parent 330dc7d2a4276ca3af24314e6069fe8245b84af1
author Heschi Kreinick <heschi@google.com> 1604442389 -0500
committer Heschi Kreinick <heschi@google.com> 1604515022 +0000

internal/lsp: set correct directness when adding new requires

When adding a require, we should add an `// indirect` comment if that's
what go mod tidy would do.

It's possible I should split Add out from Update and Remove, but this
was quick and easy and I'm not too worried about it for now.

Also minimize the test that covered this case, which was way more
complicated than it needed to be AFAICT.

Fixes golang/go#38914.

Change-Id: I89c44f8573873227c4c9e637d1d31d8c1a6530aa
Reviewed-on: https://go-review.googlesource.com/c/tools/+/267578
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>