| commit | aefe0b742155c39732b3f30c66aa1b2eee9f2bcd | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Tue Nov 03 17:26:29 2020 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Wed Nov 04 18:37:02 2020 +0000 |
| tree | 38e34ee53f061cba41ccc98dcdaf0d776fa39329 | |
| parent | 330dc7d2a4276ca3af24314e6069fe8245b84af1 [diff] |
internal/lsp: set correct directness when adding new requires When adding a require, we should add an `// indirect` comment if that's what go mod tidy would do. It's possible I should split Add out from Update and Remove, but this was quick and easy and I'm not too worried about it for now. Also minimize the test that covered this case, which was way more complicated than it needed to be AFAICT. Fixes golang/go#38914. Change-Id: I89c44f8573873227c4c9e637d1d31d8c1a6530aa Reviewed-on: https://go-review.googlesource.com/c/tools/+/267578 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.