commit | ae0deb7a4c9d16406b4c2a32fd9442bc3faf079b | [log] [tgz] |
---|---|---|
author | Suzy Mueller <suzmue@golang.org> | Thu Jun 24 11:53:41 2021 -0400 |
committer | Suzy Mueller <suzmue@golang.org> | Tue Jul 13 14:00:16 2021 +0000 |
tree | 4a394dca295421139734debbad02e84434e12521 | |
parent | d36a54b56b46cb3de852f65cec98b6a563ff8011 [diff] |
internal/lsp: fix variable reuse bug in code actions Taking the address of the variables defined by range in a for loop is not safe since they are reused. Get the address from the original slice. Change-Id: If7fbf3fdbfeeaf329f36e416642582002895bbce Reviewed-on: https://go-review.googlesource.com/c/tools/+/330649 Trust: Suzy Mueller <suzmue@golang.org> Run-TryBot: Suzy Mueller <suzmue@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.