commit | add869b66535e4ddb123b4b880183049c62e54a2 | [log] [tgz] |
---|---|---|
author | Rebecca Stambler <rstambler@golang.org> | Fri Feb 12 01:12:03 2021 -0500 |
committer | Rebecca Stambler <rstambler@golang.org> | Fri Feb 12 21:26:46 2021 +0000 |
tree | d9a839c5a6835da74c40d30d0cb9e989a9a69a80 | |
parent | 701d1429d86f6d6ec132f6459112e90efa26ae93 [diff] |
internal/lsp: always return file handles for nonexistent files findFile has a case that returns early if the file does not exist. Handle this error in getFile to avoid inconsistently returning errors when getting file handles for files that don't exist. Unskip the test, since it is no longer flaky. Fixes golang/go#44227 Change-Id: I07a4f860cfc9f852728c31706bd924e419bd54e2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/291391 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.