| commit | ad473c03aa65297ab7b5c17f80d284b6a8d96504 | [log] [tgz] |
|---|---|---|
| author | Rohan Challa <rohan@golang.org> | Tue Dec 10 11:51:34 2019 -0500 |
| committer | Rohan Challa <rohan@golang.org> | Wed Dec 11 23:24:34 2019 +0000 |
| tree | fdd840e4b9c0ebcfe5c78b74be7aece15caaf34e | |
| parent | 4da4485a1cd91d12f7ac9639b46f51587bda69fd [diff] |
internal/lsp: add handling for go.mod files in internal/lsp functions When we are processing a go.mod file, we are calling go/packages.load when we should not be. It will always return 0 packages since it is not a .go file. This CL adds branching inside each internal/lsp protocol function and also adds a check in snapshot.PackageHandles for the file type and returns an error. This will prevent `go list` from running on go.mod files for now. Updates golang/go#31999 Change-Id: Ic6d0e9b7c81e1f404342b98e10b9c5387adde2ee Reviewed-on: https://go-review.googlesource.com/c/tools/+/210757 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rohan Challa <rohan@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.