tree 5e8e181e025858ff71ba45ec1551d1214693b0b2
parent 07bc1bf47fb2e2433bf1afd8647579c4329c9203
author Scott Cotton <scott@mindowl.com> 1627072013 +0200
committer Robert Findley <rfindley@google.com> 1627565667 +0000

go/pointer: fix constraint gen for *ssa.Next

The existing implementation has an error coordinating the types of the
expressions 'k, v' in a range statement over a map 'k, v := range m'.
In particular, 'k', 'v' may have types other than the key and value
types of m and the difference between these types affects the constraint
generation of *ssa.Next (used to model iterating over maps).  This fix
simply calculates the offset of the destination (the *types.Tuple of
*ssa.Next) independently from the offset of the source (the map 'm' in
the example above).

Fixes golang/go#45735

Change-Id: Ib11846a94c23f8815fa502bdb7f80ef0803bf182
Reviewed-on: https://go-review.googlesource.com/c/tools/+/335889
Reviewed-by: Tim King <taking@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Trust: Tim King <taking@google.com>
Run-TryBot: Tim King <taking@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>