| commit | ab1fe7202b0a817c16909ae27c5ad518802c0d6a | [log] [tgz] |
|---|---|---|
| author | Scott Cotton <scott@mindowl.com> | Fri Jul 23 22:26:53 2021 +0200 |
| committer | Robert Findley <rfindley@google.com> | Thu Jul 29 13:34:27 2021 +0000 |
| tree | 5e8e181e025858ff71ba45ec1551d1214693b0b2 | |
| parent | 07bc1bf47fb2e2433bf1afd8647579c4329c9203 [diff] |
go/pointer: fix constraint gen for *ssa.Next The existing implementation has an error coordinating the types of the expressions 'k, v' in a range statement over a map 'k, v := range m'. In particular, 'k', 'v' may have types other than the key and value types of m and the difference between these types affects the constraint generation of *ssa.Next (used to model iterating over maps). This fix simply calculates the offset of the destination (the *types.Tuple of *ssa.Next) independently from the offset of the source (the map 'm' in the example above). Fixes golang/go#45735 Change-Id: Ib11846a94c23f8815fa502bdb7f80ef0803bf182 Reviewed-on: https://go-review.googlesource.com/c/tools/+/335889 Reviewed-by: Tim King <taking@google.com> Reviewed-by: Robert Findley <rfindley@google.com> Trust: Tim King <taking@google.com> Run-TryBot: Tim King <taking@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.