tree 919300274b1460af1079e642b9db68b7465aec81
parent 2c860bdd6e788e473e1f01b87efa55ad87450d39
author Peter Weinbergr <pjw@google.com> 1606010943 -0500
committer Peter Weinberger <pjw@google.com> 1606221381 +0000

internal/lsp: revise some semantic token details

There was a bug and inconsistency in how const identifiers were
categorized when being used. The new code always makes them readonly
variables.

The predeclared identifiers (true, false, nil, iota) were treated
inconsistently. The new code makes them all readonly variables.

Under rare conditions the output from gopls semtok was not syntactic
Go code because is would put a /* comment immediately after an
operator /, thereby generating a spurious line comment.

Fixes golang/go#42715

Change-Id: I5b1ccfaf607d6baa58c132e460c5617db6634a72
Reviewed-on: https://go-review.googlesource.com/c/tools/+/272208
Trust: Peter Weinberger <pjw@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>