tree 20e09b78006b7d959c0c93baf8a38785c1488826
parent 271e621c9735573bbab95ad33f04333a75c97f95
author Robert Findley <rfindley@google.com> 1674169938 -0500
committer Robert Findley <rfindley@google.com> 1674182564 +0000

gopls/internal/lsp: consolidate the FileHandle API

Clean up several aspects of the FileHandle APIs.
- Eliminate the VersionedFileHandle. There is no need for this
  specialization, when we already had the closedFile wrapper to make an
  on-disk file satisfy the Versioning interface.
- Remove the VersionedFileIdentity concept. This was an artifact of an
  earlier time when we stored files across sessions, views, and
  snapshots. In all remaining uses, a snapshot is implied.
- Clean up now-unnecessary APIs accordingly.
- Rename cache.fileHandle and cache.overlay to cache.DiskFile and
  cache.Overlay. There was some convenience to exporting Overlay, and
  DiskFile was exported for symmetry.
- Remove a bunch of unnecessary test boilerplate.
- Remove the link from Overlay to Session, as it was only necessary for
  debug templates.

Change-Id: I3cbf599c260d8e53c8ace913bbf92b2c6f054d3a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/462818
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>