| commit | 82366c69603a2b68eb7d18b95cdca8bbd6b64558 | [log] [tgz] |
|---|---|---|
| author | Bryan C. Mills <bcmills@google.com> | Wed Feb 02 11:00:09 2022 -0500 |
| committer | Bryan Mills <bcmills@google.com> | Thu Feb 03 05:58:33 2022 +0000 |
| tree | c0d82fa0f78d0c8a320469e21558a945a27b6021 | |
| parent | f6067dc943539f9a9eb711eb51b35b2fe9b7f9f5 [diff] |
internal/lsp/fake: in WriteFileData, retry writes that fail with ERROR_LOCK_VIOLATION on Windows The 'go' command reads the main module's 'go.mod' file with the file locked. If 'gopls' starts a 'go' command in the background that reads the 'go.mod' file, there is a narrow window in which that read can race with the test's ioutil.WriteFile. This change retries the write (as a user would probably do), fixing the test failure. However, I suspect that there may be a broader UX issue here that it will mask: in order to actually avoid the race without a locking error, something in the LSP protocol needs to be synchronizing gopls-initiated reads with editor-initiated writes. The test failure this fixes indicates that that synchronization seems not to be happening. Fixes golang/go#50971 Change-Id: Iba140277bf957bae4937cc23f62d3aac817a7d36 Reviewed-on: https://go-review.googlesource.com/c/tools/+/382414 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go install.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go install golang.org/x/tools/...@latest.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.