tree ee4a3ac82820d1e5c5122ecd7da66f7151ae1178
parent 53d48bfcf544a006a229aeb4d4ffdb6c4c9fa855
author Muir Manders <muir@mnd.rs> 1575610457 -0800
committer Rebecca Stambler <rstambler@golang.org> 1576532189 +0000

internal/lsp: fix find-implementation for promoted methods

We weren't returning promoted methods as implementations when the
promoted method was defined in a different package than the type
implementing the interface.

Fix by properly mapping the implementer types.Object to its containing
source.Package.

I generalized the implementations() result to just contain the
implementer objects and their containing package. This allowed me to
get rid of some result prep code in Implementation().

Fixes golang/go#35972.

Change-Id: I867f2114c34e2ad39515ee3c8b6354c1cd35f7af
Reviewed-on: https://go-review.googlesource.com/c/tools/+/210280
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>