tree f701a639bb22835693ff2c787ad0217b5c5ed34e
parent 3810fa8296bd35d6bc1a354d837a84ea032a7672
author Suzy Mueller <suzmue@golang.org> 1627679561 -0600
committer Suzy Mueller <suzmue@golang.org> 1627931164 +0000

internal/lsp: find references for ident before selector

Previously, if the position was before the "." in a selector,
pathEnclosingObjNode would move the position to right after the
".". This created confusing behavior where editors would highlight
the identifier before the ".", but references and go to definition
would be applied on the identified after the selector. This change
removes the shifting of the position if found on a selector.

Fixes golang/go#47408

Change-Id: If2504e7d5af2fae24b97c5c1e88b9cbe67aaaaf3
Reviewed-on: https://go-review.googlesource.com/c/tools/+/338789
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>