commit | 8ceaad4c15e6280f9cb3cc2d71f7f11e3aa89a35 | [log] [tgz] |
---|---|---|
author | Heschi Kreinick <heschi@google.com> | Tue Nov 05 17:33:19 2019 -0500 |
committer | Heschi Kreinick <heschi@google.com> | Thu Nov 07 22:26:10 2019 +0000 |
tree | 2bea38253233eb7b856f84c27447e59b3581f874 | |
parent | 0c330b00b1a74f19a7237de8f5c46b9483084fa2 [diff] |
internal/lsp/source: don't format the whole file when adding imports We want people to add imports as they need them. That means we probably don't want adding an import to reformat your whole file while you're in the middle of editing it. Unfortunately, the AST package doesn't offer any help with this -- there's no good way to get a diff out of it. Instead, we apply the changes, then diff a subset of the file. Picking that subset is tricky, see the code for details. Also delete a dead function, Imports, which should have been unused but was still being called in tests. Fixes golang/go#30843. Change-Id: I09a5344e910f65510003c4006ea5b11657922315 Reviewed-on: https://go-review.googlesource.com/c/tools/+/205678 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.