| commit | a22008757fdeb4827d155b7817c0cae489d3ac20 | [log] [tgz] |
|---|---|---|
| author | Bryan C. Mills <bcmills@google.com> | Tue Apr 12 15:59:56 2022 -0400 |
| committer | Gopher Robot <gobot@golang.org> | Tue Apr 12 20:21:55 2022 +0000 |
| tree | dfae7bc1d2a159f79972ad07c88903f3f9b9e233 | |
| parent | d5f48fca5379171ebce583082a3dd683c8f8ad75 [diff] |
internal/lsp/protocol: ignore reply values with non-nil errors in jsonrpc2_v2 adapters The documentation for jsonrpc2.Replier states that “[i]f err is set then result will be ignored.” jsonrpc2_v2 documents no such affordance, and the JSON-RPC 2.0 protocol explicitly requires that the result “MUST NOT exist if there was an error invoking the method.” Although CL 388600 already avoids returning values in case of error (which may also help with escape analysis and/or allocation efficiency), it seems simplest and least confusing to make the semantic difference between the jsonrpc2.Handler and jsonrpc2_v2.Handler explicit in the code. For golang/go#46520. Change-Id: If13eb842505d42cbc51c01f5f5e699a549a3a28b Reviewed-on: https://go-review.googlesource.com/c/tools/+/400054 Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go install.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go install golang.org/x/tools/...@latest.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.