tree 8e23fd79412b121eeb79ab713da728cf1b6c5da7
parent 4aa5c68dc7ae79da9ac744d016fd4569a1825e8e
author Rebecca Stambler <rstambler@golang.org> 1600306470 -0400
committer Rebecca Stambler <rstambler@golang.org> 1600721150 +0000

internal/lsp: rewrite createView to populate fields independently

The logic of incrementally populating the view was getting unnecessarily
complicated and hard to reason about. Split out helper functions that
we can use to create the view's fields before creating it.

Change-Id: I872fe22a9c2802668facf6b2d795b195aa47de00
Reviewed-on: https://go-review.googlesource.com/c/tools/+/255348
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>