)]}'
{
  "commit": "a1c56757aa42df2baa8ff0c660a0ce2b468f1723",
  "tree": "7fe9a7f88a28e885db14557319232eba65a735de",
  "parents": [
    "ae19ec714359fc93998078066daf8cb98ee23fb7"
  ],
  "author": {
    "name": "Ian Cottrell",
    "email": "iancottrell@google.com",
    "time": "Fri Feb 28 22:55:50 2020 -0500"
  },
  "committer": {
    "name": "Ian Cottrell",
    "email": "iancottrell@google.com",
    "time": "Tue Mar 03 22:56:24 2020 +0000"
  },
  "message": "internal/telemetry: remove the concept of a Tagger\n\nThe Tagger interface allowed for specifying a key in a tag list and having the\nvalue be aquired from the context automatically. It was almost never used, and\nthe alternative (using the key to get the value) is not that much more long\nwinded, so it was not holding it\u0027s own weight from a complexity persective alone\nbut the performance cost of having to use a list of interface rather than a list\nof tags was very large. See the benchstat improvements below for the difference\nit makes to both speed and memory usage, especially in the no exporter case.\n\nname                 old time/op    new time/op    delta\nBaseline-8              341ns ± 2%     342ns ± 1%     ~     (p\u003d0.139 n\u003d19+18)\nLoggingNoExporter-8    2.46µs ± 5%    1.97µs ± 3%  -19.88%  (p\u003d0.000 n\u003d19+20)\nLogging-8              13.3µs ± 2%    12.8µs ± 2%   -3.42%  (p\u003d0.000 n\u003d17+20)\nLoggingStdlib-8        5.39µs ± 6%    5.34µs ± 3%     ~     (p\u003d0.692 n\u003d20+19)\n\nname                 old alloc/op   new alloc/op   delta\nBaseline-8              80.0B ± 0%     80.0B ± 0%     ~     (all equal)\nLoggingNoExporter-8      728B ± 0%      440B ± 0%  -39.56%  (p\u003d0.000 n\u003d20+20)\nLogging-8              2.75kB ± 0%    2.46kB ± 0%  -10.53%  (p\u003d0.000 n\u003d17+20)\nLoggingStdlib-8          568B ± 0%      568B ± 0%     ~     (all equal)\n\nname                 old allocs/op  new allocs/op  delta\nBaseline-8               5.00 ± 0%      5.00 ± 0%     ~     (all equal)\nLoggingNoExporter-8      32.0 ± 0%      23.0 ± 0%  -28.12%  (p\u003d0.000 n\u003d20+20)\nLogging-8                88.0 ± 0%      79.0 ± 0%  -10.23%  (p\u003d0.000 n\u003d20+20)\nLoggingStdlib-8          28.0 ± 0%      28.0 ± 0%     ~     (all equal)\n\nChange-Id: Ic203ad0c5de7451348976b999a0d038ac532dc39\nReviewed-on: https://go-review.googlesource.com/c/tools/+/221737\nRun-TryBot: Ian Cottrell \u003ciancottrell@google.com\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Robert Findley \u003crfindley@google.com\u003e\nReviewed-by: Emmanuel Odeke \u003cemm.odeke@gmail.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0319c08d24f2d9a85b953644e063bda2591e2223",
      "old_mode": 33188,
      "old_path": "internal/lsp/diagnostics.go",
      "new_id": "de0e23e7f64e9ce486a845c7548480576ca10766",
      "new_mode": 33188,
      "new_path": "internal/lsp/diagnostics.go"
    },
    {
      "type": "modify",
      "old_id": "b4f2c70a21b34df4dd0050e0d851c2cf35e0f875",
      "old_mode": 33188,
      "old_path": "internal/telemetry/log/log.go",
      "new_id": "0c57e8a24caf93df4ca7f5f4f1bd6a9d233772df",
      "new_mode": 33188,
      "new_path": "internal/telemetry/log/log.go"
    },
    {
      "type": "modify",
      "old_id": "54c6102f4870e916581b4f11b33d649bee1870b8",
      "old_mode": 33188,
      "old_path": "internal/telemetry/tag.go",
      "new_id": "4af028d6dcd6a574d627e1ba8e367dce7f96761d",
      "new_mode": 33188,
      "new_path": "internal/telemetry/tag.go"
    },
    {
      "type": "modify",
      "old_id": "c6192aba95a0597645a76bdb2de3a099d71b7553",
      "old_mode": 33188,
      "old_path": "internal/telemetry/tag/tag.go",
      "new_id": "2c96aaadbab5634e2014c2a3251ab04ea4e7a582",
      "new_mode": 33188,
      "new_path": "internal/telemetry/tag/tag.go"
    }
  ]
}
