| commit | ae19ec714359fc93998078066daf8cb98ee23fb7 | [log] [tgz] |
|---|---|---|
| author | Ian Cottrell <iancottrell@google.com> | Fri Dec 20 15:04:24 2019 -0500 |
| committer | Ian Cottrell <iancottrell@google.com> | Tue Mar 03 22:56:03 2020 +0000 |
| tree | af038e9e8b45b4c61401d3d3e723383052c797b0 | |
| parent | 4183ba16a9adbc10c114828db9f7f7e2f4a7b3fc [diff] |
internal/telemetry: use atomics to get the exporter We change the main exporter to be stored and fetched using atomics rather than aquiring a mutex for a mild (but significant in the disabled case) speedup. Also has the benefit of not holding a global lock over all telemetry operations. benchstat of logging benchmatks before and after: name old time/op new time/op delta Baseline-8 329ns ± 2% 327ns ± 2% ~ (p=0.181 n=19+17) LoggingNoExporter-8 3.08µs ± 3% 2.42µs ± 2% -21.42% (p=0.000 n=20+19) Logging-8 13.7µs ± 2% 13.2µs ± 1% -3.49% (p=0.000 n=19+19) LoggingStdlib-8 5.39µs ± 3% 5.41µs ± 2% ~ (p=0.177 n=19+20) This is a replacement for https://go-review.googlesource.com/c/tools/+/212244 but built on the single exporter principle rather than the exporter list. Change-Id: Icc99319c4357e0bcb63386c64372a733e8a76796 Reviewed-on: https://go-review.googlesource.com/c/tools/+/221218 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.