| commit | a199121ba984e632dd1256b5b69bbb2981f5a3b3 | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Fri Oct 18 15:05:43 2024 +0000 |
| committer | Robert Findley <rfindley@google.com> | Fri Oct 18 20:45:24 2024 +0000 |
| tree | d9e6306dd558cfb574b871dfee74c7013cc43631 | |
| parent | 8ecf757a9656a2200382fcfcd690daa470d33341 [diff] |
gopls: allow for asynchronous request handling As described in golang/go#69937, we need a mechanism that allows for concurrent request handling in gopls. However, this cannot be implemented entirely within the jsonrpc2 layer, because we need gopls to observe requests in the order they arrive, so it can handle them with the correct logical state. This CL adds such a concurrency mechanism using a trick similar to t.Parallel. Specifically, a new jsonrpc2.Async method is introduced which, when invoked on the request context, signals the jsonrpc2.AsyncHandler to start handling the next request. Initially, we use this new mechanism within gopls to allow certain long-running commands to execute asynchronously, once they have acquired a cache.Snapshot representing the current logical state. This solves a long-standing awkwardness in the govulncheck integration, which required an additional gopls.fetch_vulncheck_result command to fetch an asynchronous result. This enables some code deletion and simplification, though we could simplify further. Notably, change the code_action subcommand to eliminate the progress handler registration, since we don't need progress to know when a command is complete. Instead, use -v as a signal to log progress reports to stderr. Fixes golang/go#69937 Change-Id: I8736a445084cfa093f37c479d419294d5a1acbce Reviewed-on: https://go-review.googlesource.com/c/tools/+/621055 Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph prints the call graph of a Go program.cmd/digraph is a utility for manipulating directed graphs in textual notation.cmd/stringer generates declarations (including a String method) for “enum” types.cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis provides a framework for modular static analysis of Go programs.
go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg provides a simple control-flow graph (CFG) for a Go function.
go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.
go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.