commit | a13dbf1ae06d5f91945e3d4babf6e99d6d215aa9 | [log] [tgz] |
---|---|---|
author | Muir Manders <muir@mnd.rs> | Sat Apr 17 09:52:11 2021 -0700 |
committer | Rebecca Stambler <rstambler@golang.org> | Tue Apr 20 15:21:37 2021 +0000 |
tree | 358c453fa80adefe4241b22fbc3c62c7a0270b2d | |
parent | 10909d8c27144a43f7482b9e58f2d4dc07483347 [diff] |
lsp/completion: omit deep completions into unimported package names Don't offer deep completions when completing the name of unimported packages. For example: var _ int = <> Completing at <> previously would offer an eclectic array of candidates such as "bits.LeadingZeros()", "time.Now().Day()", or "zlib.BestCompression", depending on your luck. These candidates stem from unimported packages candidates such as "bits" which we continue searching into for deep candidates. There are two main reasons these deep completions are not useful: 1. They are not dependable. Not all unimported packages are even searched (it stops as soon as it finds a set number). 2. Fuzzy matching does not work (e.g. typing "bilz" will not filter to "bits.LeadingZeros" as it does in other cases). 2) could be remedied, but there are so many unimported package members that I'm not sure it is possible to reduce false positive deep completions to a satisfactory level. I also made a couple relevant minor tweaks: - Fallback sort the unimported packages by path to keep a consistent order. - Don't offer unimported packages at all if there is no prefix. Updates golang/go#43374. Change-Id: I9fbcde34a3a9e7781568515bddab9da2fc931139 Reviewed-on: https://go-review.googlesource.com/c/tools/+/311069 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.