tree b87a1be68a880d24e6ab8aadb32bfc44f3c98c4a
parent 6f567c8090cb88f13a71b19595bf88c6b27dbeed
author Alan Donovan <adonovan@google.com> 1686068490 -0400
committer Robert Findley <rfindley@google.com> 1686082730 +0000

internal/typeparams: work around LookupFieldOrMethod inconsistency

This change adds to x/tools a workaround for a bug in go/types
that causes LookupFieldOrMethod and NewTypeSet to be inconsistent
wrt an ill-typed method (*T).f where T itself is a pointer.

The workaround is that, if Lookup fails, we walk the MethodSet.

Updates golang/go#60634
Fixes golang/go#60628

Change-Id: I87caa2ae077e5cdfa40b65a2f52e261384c91167
Reviewed-on: https://go-review.googlesource.com/c/tools/+/501197
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>