| commit | 0a46fa39b0518991fd295afa50ddf2094cd2fe71 | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Tue Mar 31 13:19:04 2020 -0400 |
| committer | Heschi Kreinick <heschi@google.com> | Thu Apr 02 17:48:25 2020 +0000 |
| tree | 91fc8782c27b5af74a86a4de31c2b95405cdedd3 | |
| parent | 3304cfb00fb25f09cda462560ddd772745c198ce [diff] |
internal/lsp/source: propose loaded unimported package names first When proposing unimported package members, we start with packages loaded in-memory first, for three reasons: we know that they're fast, they're fully typed, and they're probably pretty relevant. I hadn't bothered doing that for package names, because the first two reasons aren't very relevant. But the third still is -- loaded packages are a pretty good approximation for in module scope, etc. With this change we do package names the same as members, so relevance should be about as good. Not perfect, but nobody's complained much yet. Fair bit of copy-and-paste, but I don't want to extend the getAllCandidates abstraction outside of the imports package yet. Updates #38104. Change-Id: Ia479181607dff898baee3cd6aa84d1ab61715d19 Reviewed-on: https://go-review.googlesource.com/c/tools/+/226559 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.