Google Git
Sign in
go / tools / 9ec855317b921fef87bad6bf492ef7cd0d431db8
commit9ec855317b921fef87bad6bf492ef7cd0d431db8[log] [tgz]
authorAlan Donovan <adonovan@google.com>Thu Dec 08 17:25:47 2022 -0500
committerAlan Donovan <adonovan@google.com>Tue Dec 13 19:48:12 2022 +0000
treed3cb33464b8dfb70c7256fc5559a68f0f4f2d683
parent444c8f69ae8bb5efb58c8aa8a00fc14f6a5d1de7 [diff]
gopls/internal/lsp/source: emit interface stub methods at top level

Before, the insertion point of the new methods was after the
TypeSpec that declared the concrete type, but that isn't valid
if the containing GenDecl is parenthesized.
This change causes it to insert the methods after the decl.

Also
- a regression test
- a would-be test of attempting to stub a function-local type,
  but the test framework cannot express errors yet.
- sort embedded interfaces, since go/types changed its sort
  order in go1.18, and this CL's new test is the first time
  it has been exercised with an interface (io.ReadCloser) that
  has more than one embedded interface.
  Needless to say, figuring that out took 10x more time
  than actually fixing the reported bug.

Fixes golang/go#56825

Change-Id: I0fc61f297befd12e8a7224dcbd6a197cf9e4b1cf
Reviewed-on: https://go-review.googlesource.com/c/tools/+/456316
Run-TryBot: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
6 files changed
tree: d3cb33464b8dfb70c7256fc5559a68f0f4f2d683
  1. benchmark/
  2. blog/
  3. cmd/
  4. container/
  5. copyright/
  6. cover/
  7. go/
  8. godoc/
  9. gopls/
  10. imports/
  11. internal/
  12. playground/
  13. present/
  14. refactor/
  15. txtar/
  16. .gitattributes
  17. .gitignore
  18. .prettierrc
  19. codereview.cfg
  20. CONTRIBUTING.md
  21. go.mod
  22. go.sum
  23. LICENSE
  24. PATENTS
  25. README.md
README.md

Go Tools

PkgGoDev

This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.

It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.

Selected commands:

  • cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.
  • cmd/callgraph prints the call graph of a Go program.
  • cmd/digraph is a utility for manipulating directed graphs in textual notation.
  • cmd/stringer generates declarations (including a String method) for “enum” types.
  • cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.

These commands may be fetched with a command such as

go install golang.org/x/tools/cmd/goimports@latest

Selected packages:

  • go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.

  • go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.

  • go/analysis provides a framework for modular static analysis of Go programs.

  • go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.

  • go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.

  • go/cfg provides a simple control-flow graph (CFG) for a Go function.

  • go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.

  • go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.

  • go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.

Numerous other packages provide more esoteric functionality.

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.

The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.

JavaScript and CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.