commit | 9dfac01ddd86037d8f36e89051430ce31f180597 | [log] [tgz] |
---|---|---|
author | Heschi Kreinick <heschi@google.com> | Wed May 12 11:48:48 2021 -0400 |
committer | Heschi Kreinick <heschi@google.com> | Wed May 12 16:42:30 2021 +0000 |
tree | 8eb0d5d82cd2fe4a5376e334a456234de2024156 | |
parent | be4aaae4cf865bd1e65ae3a22df28c1f47b6ccfd [diff] |
internal/lsp/cache: add missing error checks I wrote this code as if there was going to be a final error check after all the type checking attempts, but ended up using the result inside the attempts, errors would likely have resulted in panics. Just do normal, non-clever error checking. Change-Id: I665f34f7e6d1a2c3465543cbdc39a723a22a1095 Reviewed-on: https://go-review.googlesource.com/c/tools/+/319371 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.