internal/lsp/cache: invalidate broken packages when imports are deleted

In the presence of an import cycle, packages.Load will exclude the
problematic import from Package.Imports. This missing edge means that we
wouldn't correctly invalidate broken package metadata when a problematic
import is deleted. We also weren't treating import deletion as a change
that could invalidate metadata.

Fix this by invalidating any broken packages when an import path is
deleted, anywhere. This could be overly coarse, but there are various
problems with trying to do better.

Also change cycle errors from TypeError to ListError, as this
categorization was misleading.

Fixes golang/go#46667

Change-Id: Id19e7baf4009632caf3ae9365497552f9b64b5c7
Trust: Robert Findley <>
Run-TryBot: Robert Findley <>
gopls-CI: kokoro <>
TryBot-Result: Go Bot <>
Reviewed-by: Rebecca Stambler <>
3 files changed
tree: e0c8f5645ecbc3e816e9da0cc73eec763301b46b
  1. .gitattributes
  2. .gitignore
  3. .prettierrc
  10. benchmark/
  11. blog/
  12. cmd/
  13. codereview.cfg
  14. container/
  15. copyright/
  16. cover/
  17. go.mod
  18. go.sum
  19. go/
  20. godoc/
  21. gopls/
  22. imports/
  23. internal/
  24. playground/
  25. present/
  26. refactor/
  27. txtar/

Go Tools


This subrepository holds the source for various packages and tools that support the Go programming language.

Some of the tools, godoc and vet for example, are included in binary Go distributions.

Others, including the Go guru and the test coverage tool, can be fetched with go get.

Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.


The easiest way to install is to run go get -u You can also manually git clone the repository to $GOPATH/src/

JS/CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see

The main issue tracker for the tools repository is located at Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.